Skip to content

feat(linter): add codespell linter #4143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

feat(linter): add codespell linter #4143

wants to merge 4 commits into from

Conversation

ideaship
Copy link
Contributor

Add the codespell linter which uses a dictionary of common misspellings and ignores unknown words.

Fixes #4140

Proposed Changes

Add the codespell linter which uses a dictionary of common misspellings and ignores unknown words.

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@ideaship ideaship marked this pull request as draft October 16, 2024 08:48
@ideaship
Copy link
Contributor Author

@nvuillam The PR I created is failing for reasons that are not obvious to me. I will hopefully get around to take another look tomorrow. Hints welcome.

nvuillam
nvuillam reviewed Oct 16, 2024
View reviewed changes
megalinter/descriptors/spell.megalinter-descriptor.yml
@@ -211,3 +211,39 @@ linters:
dockerfile:
- FROM lycheeverse/lychee:latest-alpine AS lychee
- COPY --link --from=lychee /usr/local/bin/lychee /usr/bin/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quality :)

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Dec 28, 2024
@github-actions github-actions bot closed this Jan 11, 2025
@bdovaz bdovaz reopened this Jan 11, 2025
@github-actions github-actions bot removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Jan 12, 2025
@bdovaz
Copy link
Collaborator

bdovaz commented Jan 17, 2025

@ideaship can you resolve the conflicts and merge main in your branch and try to unlock this PR? Thanks.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Feb 17, 2025
@bdovaz bdovaz removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Feb 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Mar 20, 2025
@github-actions github-actions bot closed this Apr 4, 2025
@echoix echoix reopened this Apr 4, 2025
@github-actions github-actions bot removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Apr 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 5, 2025

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label May 5, 2025
@github-actions github-actions bot closed this May 19, 2025
@bdovaz bdovaz reopened this May 19, 2025
@github-actions github-actions bot removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label May 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Jun 20, 2025
@github-actions github-actions bot closed this Jul 4, 2025
@ideaship
Copy link
Contributor Author

I think this PR could be reopened.

@echoix echoix removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Jul 27, 2025
@echoix
Copy link
Collaborator

echoix commented Jul 27, 2025

Hmm, the button to reopen the PR isn't available to me, even as maintainer. Was the branch deleted or something?

@nvuillam
Copy link
Member

image same for me

@echoix
Copy link
Collaborator

echoix commented Jul 27, 2025

Maybe he unchecked the box that allows us to update the PR, so only the author can do something. Probably better to open a new PR in this case

@ideaship
Copy link
Contributor Author

I did not intentionally uncheck the box that lets admins update the PR, but when I looked, it was indeed unchecked. Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvuillam nvuillam nvuillam left review comments

@echoix echoix Awaiting requested review from echoix echoix is a code owner

@bdovaz bdovaz Awaiting requested review from bdovaz bdovaz is a code owner

@Kurt-von-Laven Kurt-von-Laven Awaiting requested review from Kurt-von-Laven Kurt-von-Laven is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new linter: codespell
4 participants
@ideaship @nvuillam @bdovaz @echoix